-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(favorites): frontend revisions to pray and pay project #4580
base: main
Are you sure you want to change the base?
Conversation
@ERosendo this is the PR I'm going to build off of. |
for more information, see https://pre-commit.ci
Seeing some commit messages around the user-prayer page. Reminds me that it doesn't have to be available in the profile section, just like tags aren't. The user prayers page could just be linked from the mouseover for each emoji or from the most-wanted page, for example. |
Yeah, tags are what I am aiming to emulate. |
@ERosendo, do you think you could help, please? |
@mlissner sure! 👍 |
for more information, see https://pre-commit.ci
…rtlistener into 4507-pray-and-pay-API
@ERosendo in addition to those two issues with the buttons, I've mostly finished a MVP of the This is what it currently looks like. The status column is broken; I can't figure out why the backend isn't passing the information through to the template. I intend to add a button to allow users to delete requests and one for them to download available documents as well. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…rtlistener into 4507-pray-and-pay-API
…rtlistener into 4507-pray-and-pay-API
@v-anne, I noticed this PR is paused. Are you waiting for feedback or something else? |
Got it. We're moving to a sprint/scrum model, but I'll get this on his new list. :) |
This is the PR for making frontend changes to the pray and pay user interface.
Mike had some great comments in #4507, so we'll start with them and see what's needed once the low-hanging fruit is done.
Additions include:
recap_document.html
page.top_prayers.html
to provide better UX.user_prayers.html
page to allow users to see their open and fulfilled prayers, and also summary statistics about how many requests they've had fulfilled. In a future PR, this will be made similar to tags to allow people (e.g., freelance journalists) to share documents they've requested.