Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scrapers.update_from_text): new command #4520

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

grossir
Copy link
Contributor

@grossir grossir commented Oct 1, 2024

Helps solve: freelawproject/juriscraper#858

  • New command to re-run Site.extract_from_text over downloaded opinions
  • Able to filter by Docket.court_id , OpinionCluster.date_filed, OpinionCluster.precedential_status
  • Updates tasks.update_from_document_text to return information for logging purposes
  • Updates test_opinion_scraper to get a Site.extract_from_text method

Helps solve: freelawproject/juriscraper#858

- New command to re-run Site.extract_from_text over downloaded opinions
- Able to filter by Docket.court_id ,  OpinionCluster.date_filed, OpinionCluster.precedential_status
- Updates tasks.update_from_document_text to return information for logging purposes
- Updates test_opinion_scraper to get a Site.extract_from_text method
Copy link

sentry-io bot commented Oct 1, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: cl/scrapers/tasks.py

Function Unhandled Issue
update_document_from_text IndexError: list index out of range cl.scrapers.t...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

@grossir grossir requested a review from flooie October 1, 2024 18:06
cl/scrapers/tasks.py Outdated Show resolved Hide resolved
@grossir grossir force-pushed the scrapers_update_from_text_command branch 4 times, most recently from 2838202 to 6a1fadb Compare October 28, 2024 18:17
- validate citation objects from `Site.extract_from_text`. Add tests for this
- abstract --courts required argument for scrapers into ScraperCommand class
also, made it more flexible
- refactor cl_scrape_opinions; cl_scrape_oral_arguments to account for this
- delete cl.scrapers.utils.extract_recap_documents which was generating a
circular import. This function was not used anywhere
@grossir grossir force-pushed the scrapers_update_from_text_command branch from 6a1fadb to ce22a58 Compare November 8, 2024 16:25
@grossir grossir force-pushed the scrapers_update_from_text_command branch from f43e855 to abc27aa Compare November 8, 2024 18:01
@grossir grossir requested a review from flooie November 8, 2024 18:18
cl/lib/juriscraper_utils.py Outdated Show resolved Hide resolved
@flooie
Copy link
Contributor

flooie commented Nov 21, 2024

@grossir just a few comments. This looks good and close.

@flooie flooie assigned grossir and unassigned flooie Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants