feat(opinion): Add ordering key #4496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres requires ordering for distinct columns and since ordering_key is one we need to sort by cluster and ordering key before we can distinct
flooie
requested review from
ERosendo and
mlissner
and removed request for
ERosendo
mlissner
reviewed
Sep 26, 2024
| @@ -3472,6 +3472,7 @@ class Meta: | |||
| name="unique_opinion_ordering_key", | |||
| ) | |||
| ] | |||
| ordering = ["ordering_key"] | |||
There was a problem hiding this comment.
I don't think I'd approach this this way. The problem with doing this is that it would apply the ordering everywhere, which imposes a performance penalty to queries where we don't care about the ordering. I think this is one of those django features that are considered an anti-pattern these days.
Can you refactor to apply the ordering only where we need and want it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ordering key to Opinion class meta field for sub opinions