Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean out old OSSEC diff and state files #7327

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Nov 7, 2024

Status

Ready for review

Description of Changes

These files are never pruned by OSSEC so they tend to accumulate, which can be a big deal for very big binary files like the ones in /boot.

A script triggered by a daily timer will now clean up old state and diff files that are more than a year old.

Fixes #7325.

Testing

How should the reviewer test this PR?

  • visual review
  • staging CI passes (contains simulated test for this)

It is hard to test in a realistic scenario unless you have a long running instance with a lot of these files accumulated over the years. IMO the simulated testing should be sufficient for now and we can do more sophisticated testing with old instance snapshots later (once other changes have accumulated too).

Deployment

Any special considerations for deployment? n/a

Checklist

@legoktm legoktm added the noble Ubuntu Noble related work label Nov 7, 2024
@legoktm legoktm requested a review from a team as a code owner November 7, 2024 19:01
@legoktm legoktm added this to the SecureDrop 2.11.0 milestone Nov 7, 2024
These files are never pruned by OSSEC so they tend to accumulate, which
can be a big deal for very big binary files like the ones in /boot.

A script triggered by a daily timer will now clean up old state and diff
files that are more than a year old.

Fixes #7325.
@legoktm
Copy link
Member Author

legoktm commented Nov 7, 2024

(last push was a rebase)

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on visual review.

@legoktm legoktm added this pull request to the merge queue Nov 8, 2024
Merged via the queue into develop with commit 543691c Nov 8, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
noble Ubuntu Noble related work
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Clean up leftover OSSEC diff files
2 participants