Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust toolchain to 1.74.0 #7078

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Update Rust toolchain to 1.74.0 #7078

merged 1 commit into from
Nov 22, 2023

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Nov 16, 2023 •
edited by zenmonkeykstop
Loading

Status

Ready for review

Description of Changes

Fixes #7077.

Testing

How should the reviewer test this PR?

  • CI passes, including deb building and staging build
  • Build new debs, deploy on a staging/prod instance:
    • Create a new source, upload a file.
    • Create new journalist, log in as them.
    • As the journalist, download the file and successfully decrypt it.

Deployment

Any special considerations for deployment? No

Checklist

  • Linting (make lint) and tests (make test) pass in the development container

@legoktm legoktm marked this pull request as ready for review November 17, 2023 15:20
@legoktm legoktm requested a review from a team as a code owner November 17, 2023 15:20
zenmonkeykstop
zenmonkeykstop approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test plan checks out.

@zenmonkeykstop zenmonkeykstop merged commit 4d9b74b into develop Nov 22, 2023
14 checks passed
@legoktm legoktm mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenmonkeykstop zenmonkeykstop zenmonkeykstop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Rust 1.74.0
2 participants
@legoktm @zenmonkeykstop