Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have update_version.sh update the RPM spec changelog too #1124

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jul 3, 2024

Status

Ready for review

Description

Use rpmdev-bumpspec tool to update the version field and automatically generate a new changelog entry.

Fixes #804.

Testing

  • Try the script, see that it bumps version + changelog correctly

Deployment

Any special considerations for deployment? n/a

Use rpmdev-bumpspec tool to update the version field and automatically
generate a new changelog entry.

Fixes #804.
@rocodes rocodes self-assigned this Jul 8, 2024
@rocodes
Copy link
Contributor

rocodes commented Jul 8, 2024

is rpmdev-bumpspec/ rpmdevtools available on Debian (and/or if not do we want to make explicit that this is done in a fedora environment) (or the container, but that seems kind of a lot)? Memory's hazy but that may be why we were still using sed.

@legoktm
Copy link
Member Author

legoktm commented Jul 8, 2024

No, it's not :/ Probably not worth making this script require Fedora/containers, I think we could just copy the small bits of https://pagure.io/rpmdevtools/blob/main/f/rpmdev-bumpspec#_183 into the script? 🤔

@zenmonkeykstop zenmonkeykstop marked this pull request as draft August 8, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

Automate dom0-config changelog entry
2 participants