Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checksums of wheels rebuilt on bookworm #1974

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Apr 23, 2024

Status

Ready for review, pending freedomofpress/securedrop-builder#497

Description

These wheels are being rebuilt in freedomofpress/securedrop-builder#497 because of some changes in the underlying debug information.

Test Plan

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration is self-contained and applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@eloquence
Copy link
Member

eloquence commented Apr 24, 2024

Visual diff LGTM. Kicked CI and bookworm build succeeded, but looks like it still needs a rebase.

These wheels are being rebuilt in <freedomofpress/securedrop-builder#497>
because of some changes in the underlying debug information.
@legoktm
Copy link
Member Author

legoktm commented Apr 24, 2024

Rebased and ready to go!

@eloquence eloquence merged commit 63734c0 into main Apr 24, 2024
48 checks passed
@eloquence eloquence deleted the rebuild-bookworm-wheels branch April 24, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants