Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gvfs-bin dependency #1842

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Remove gvfs-bin dependency #1842

merged 1 commit into from
Feb 22, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Feb 16, 2024

Status

Ready for review

Description

This was deprecated in bullseye and removed in bookworm. It provided the gvfs-copy and gvfs-rename commands, which I couldn't find any usage of in our code.

Fixes #1787.

Test Plan

  • Visual review
  • Smoke test on a 4.1/bullseye workstation?

@legoktm legoktm requested a review from a team as a code owner February 16, 2024 17:22
@legoktm legoktm mentioned this pull request Feb 16, 2024
2 tasks
This was deprecated in bullseye and removed in bookworm. It provided
the `gvfs-copy` and `gvfs-rename` commands, which I couldn't find
any usage of in our code.

Fixes #1787.
@rocodes
Copy link
Contributor

rocodes commented Feb 22, 2024

Did a bit of looking. I suspect our gvfs-bin usage dates has do do with gio and mimetype handling (see https://packages.debian.org/buster/gnome/gvfs-bin, looks like gio was part of this package).

In stock debian 11 and 12 templates, gio is already installed, as are gvfs and gvfs-common. Running through a quick smoketest but if all's well in sd-viewer and sd-devices I'm fine to merge and make sure we test further with viewing/handling a range of file types before next release.

@rocodes rocodes merged commit 031e380 into main Feb 22, 2024
72 checks passed
@rocodes rocodes deleted the gvfs-bin branch February 22, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gvfs-bin package is deprecated in Debian bullseye and completely gone in bookworm
2 participants