-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade workstation-bootstrap packages #501
Conversation
Motivated by CVE-2024-6345 in `setuptools`. But just upgrading `setuptools` forces upgrades of `pip`, which in turn requires a newer `packaging`, which then needs a newer `flit-core`. But that is then incompatible with `pep517`, so upgrade `build` to drop that dependency. Upgraded packages: * setuptools 54.0.0 -> 70.3.0 * setuptools-scm 5.0.2 -> 8.1.0 * pip 21.3.1 -> 24.1.2 * packaging 20.9 -> 24.1 * flit-core 2.3.0 -> 3.9.0 * build 0.3.0 -> 1.2.1 * colorama is skipped, it isn't hard dependency and only needed for Windows anyways * pep517 0.9.1 -> pyproject_hooks 1.1.0 (package was kind of renamed) Dropped dependencies: * pyparsing * pytoml * toml Fixes #500.
Needed because of minor metadata changes, e.g. <#500 (comment)>.
Update wheel checksums to match <freedomofpress/securedrop-builder#501>.
I will start tomorrow with the bottom of this list ( |
Discussion during last week's standup (or team meeting, I don't remember), was that reviewing pip (the last remaining review needed) is not worth it because of how large it is and how central it is to Python. @zenmonkeykstop was going to do some more historical research and put together a proposal. Now that we have most/all of the team back, I'll do a vibe check in standup if we're okay not reviewing pip and moving forward with this before the formal proposal. |
Consensus today is that we're OK not having a diff review for pip to land this, so this is now ready for review with a proper proposal to follow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed write-up, @legoktm. I've confirmed that make reprotest
passes locally.
Motivated by CVE-2024-6345 in
setuptools
. But just upgradingsetuptools
forces upgrades ofpip
, which in turn requires a newerpackaging
, which then needs a newerflit-core
. But that is then incompatible withpep517
, so upgradebuild
to drop that dependency.Upgraded packages:
Dropped dependencies:
Fixes #500.
Diff reviews
Assuming all the diff reviews from freedomofpress/securedrop#7205 are completed, we additionally need to review: