-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ip6addrctl: Reference RFC 6724 instead #1375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a very nice addition. These RFCs are standards for this implementation, right? Would you be willing to s/EE ALSO/TANDARDS/
?
Edit: If you do so, you will need a .Pp
in between the bibliographic blocks to preserve the spacing.
6191dd6
to
635d61f
Compare
Done! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please excuse me for not following though enough initially, but I had some new ideas:
Or |
Yes, but normally I do not add that line. It has usually been up to the committer. If I remember correctly, some committers have automated workflows, that add the GH pull request line, the Reviewed by line, etc. By applying the MFC line, instead of helping, I'm getting in the way.
It is a valid point. I'll also update the sample file, although it is not installed.
Yes, it usually refers to some POSIX standard(s), and normally not cited like a bibliography. These RFCs are "proposed standards", technically not standards (but mature, well-reviewed specifications). Let me know if we should move them back to the |
I recently found out that was the case for the pull request trailer, but I'm still under the impression that MFC is up to the author to suggest (and apologize I am mistaken). I still think that they belong in standards if you find that language inappropriate, but all of these choices are your own. My suggestions/questions/approval is just one reviewer's efforts to be helpful. Thanks! |
9c3dc6b
to
d3a7373
Compare
cc701dd
to
260d1ec
Compare
8dd6043
to
529b155
Compare
While I also agree, I'll leave it under
Highly appreciated, thank you! |
If you provide some instructions, I would be happy to test this change. |
It is no big deal, We'll be using The KAME project site for testing, as a tribute to the FreeBSD IPv6 stack. As much as I'd like to test with a dancing turtle (kame 亀), different browser implementations will make it hard. So we'll stick to the terminal.
Perhaps, a more realistic scenario would be when an organization that only uses a Unique Local Addresses (ULA) prefix internally, and Network Prefix Translates (NPTv6) it into a Global Unicast Addresss (GUA) prefix (some network administrators are used to a similar setup with IPv4). The problem is that ULAs have a precedence of At any rate, this is a not-so-exciting change. It is mostly a documentation update, there is really nothing to test. But thank you for the offer! Although, there is an effort to modernize/cleanup some userland utilities, by using |
cc/ @hrs-allbsd @lwhsu |
@glebius does this change look ok to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Since the sample configuration file is not installed, simply dropping it might be another option.
Thanks @jlduran! Awesome detailed instructions! |
To be fair, don't feel myself expert here. Maybe @AlexanderChernikov or @bu7cher can help? |
Commit e695500 updated the policy table to match RFC 6724, which obsoletes RFC 3484. Add a reference to RFC 6724, and mark it up as a technical report (%R). MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: freebsd#1375
Update the sample ip6addrctl.conf.sample file to match the default policy, currently based on RFC 6724. MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: freebsd#1375
Reviewed by: imp, glebius Pull Request: freebsd#1375
f581bc3
to
6197105
Compare
Reviewed by: imp, emaste Pull Request: freebsd#1356
This provides functionality for a click which is partially unreleased and then allows the user to continue moving the mousepad as if were not invoked as a full click Signed-off-by: Joshua Rogers <[email protected]> Reviewed by: imp, wulf Pull Request: freebsd#1365
This patch allows scrolling with multiple fingers simultaneously, in line with how wsp trackpads function on MacOS. Two new tunables are added: hw.usb.wsp.max_finger_area and hw.usb.wsp.max_double_tap_distance. max_finger_area defines the maximum size which the driver registered an object on trackpad as a finger. Previously, this value was hardcoded as 1200, which was too low to register thumb-clicks. max_double_tap_distance defines the maximum distance between two fingers which will register as a double-click. Signed-off-by: Joshua Rogers <[email protected]> Reviewed by: imp, wulf Pull Request: freebsd#1365
Also correctly use tun.max_double_tap_distance for maximum distance of fingers for vertical scrolling. Signed-off-by: Joshua Rogers <[email protected]> Reviewed by: imp, wulf Pull Request: freebsd#1365
The struct timespec tv_sec member is of type time_t. Make sure that all variables related to this member are of the type time_t. This is important for targets where long is a 32-bit type and time_t a 64-bit type. Reviewed by: imp Pull Request: freebsd#1373
Commit e695500 updated the policy table to match RFC 6724, which obsoletes RFC 3484. Add a reference to RFC 6724, and mark it up as a technical report (%R). MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: freebsd#1375
Update the sample ip6addrctl.conf.sample file to match the default policy, currently based on RFC 6724. MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: freebsd#1375
Reviewed by: imp, glebius Pull Request: freebsd#1375
The error was always returned, even after handling the sysctl, breaking installworld under Linux. Sponsored by: https://www.patreon.com/valpackett Reviewed by: imp Pull Request: freebsd#1376
MFC after: 3 days Reviewed by: imp Pull Request: freebsd#1378
MFC after: 3 days Reviewed by: imp Pull Request: freebsd#1379
Fixes: 86c06f (Remove GEOM_SCHED class and gsched) MFC after: 3 days Reviewed by: imp Pull Request: freebsd#1380
MFC after: 3 days Reviewed by: imp Pull Request: freebsd#1382
+ consistent document description languague with other USB-BaseT drivers + mention newly added adapters from 6ea4d9 + attempt to mention rgephy(4) phys feed into ure interfaces Fixes: 6ea4d9 (Move RTL8156 from cdce(4) to ure(4)) MFC after: 3 days Reviewed by: imp Pull Request: freebsd#1384
Signed-off-by: Tom Hukins <[email protected]> Reviewed by: imp Pull Request: freebsd#1385
Add logic that checks if the code doesn't overflow ACPI_EXTENDED_HID_DEVICE_PATH node when searching for optional strings. If the string is not provided in the device path node default value of "\0" is used. Upstream PR: https://bugzilla.tianocore.org/show_bug.cgi?id=4555 Obtained from: tianocore/edk2@96ed60d Reviewed by: imp Pull Request: freebsd#1388
Since 26b9e1f codel was fixed but traffic was not flowing for pie too. Apply the same fix. MFC after: 1 week Sponsored by: OPNsense Differential Revision: https://reviews.freebsd.org/D46182 Also see: https://redmine.pfsense.org/issues/13996 Also see: https://forum.opnsense.org/index.php?topic=41827.0 Reviewed by: imp, markj Pull Request: freebsd#1390
6197105
to
2b7f289
Compare
Update the sample ip6addrctl.conf.sample file to match the default policy, currently based on RFC 6724. MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: #1375 (cherry picked from commit 6bfbfc8)
Commit e695500 updated the policy table to match RFC 6724, which obsoletes RFC 3484. Add a reference to RFC 6724, and mark it up as a technical report (%R). MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: #1375 (cherry picked from commit 3272054)
Commit e695500 updated the policy table to match RFC 6724, which obsoletes RFC 3484. Add a reference to RFC 6724, and mark it up as a technical report (%R). MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: freebsd/freebsd-src#1375
Update the sample ip6addrctl.conf.sample file to match the default policy, currently based on RFC 6724. MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: freebsd/freebsd-src#1375
Reviewed by: imp, glebius Pull Request: freebsd/freebsd-src#1375
Commit e695500 updated the policy table to match RFC 6724, which obsoletes RFC 3484. Add a reference to RFC 6724, and mark it up as a technical report (%R). MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: freebsd/freebsd-src#1375
Update the sample ip6addrctl.conf.sample file to match the default policy, currently based on RFC 6724. MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: freebsd/freebsd-src#1375
Reviewed by: imp, glebius Pull Request: freebsd/freebsd-src#1375
Commit e695500 updated the policy table to match RFC 6724, which obsoletes RFC 3484. Add a reference to RFC 6724, and mark it up as a technical report (%R). MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: freebsd/freebsd-src#1375
Update the sample ip6addrctl.conf.sample file to match the default policy, currently based on RFC 6724. MFC after: 3 days Signed-off-by: Jose Luis Duran <[email protected]> Reviewed by: imp, glebius Pull Request: freebsd/freebsd-src#1375
Reviewed by: imp, glebius Pull Request: freebsd/freebsd-src#1375
ip6addrctl.8: Reference RFC 6724 instead
Commit e695500 updated the policy table to match RFC 6724, which obsoletes RFC 3484.
Add a reference to RFC 6724, and mark it up as a technical report (
%R
).ip6addrctl: Update the sample configuration file
Update the sample ip6addrctl.conf.sample file to match the default policy, currently based on RFC 6724.
getaddrinfo.{1,3}: Cross-reference ip6addrctl(8)