Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuageinit fixes #1342

Closed
wants to merge 3 commits into from
Closed

Nuageinit fixes #1342

wants to merge 3 commits into from

Conversation

jlduran
Copy link
Member

@jlduran jlduran commented Jul 24, 2024

Nuageinit fixes.

@jlduran
nuageinit: Fix tests
38a115e 
Commit 07d17ca set the recommended
permissions for the SSH authorized keys file and directory.  The tests,
however, were failing on CI.

Use stat to check for the proper permissions.

Fixes:	07d17ca nuageinit: Set recommended SSH permissions
Reported by:	Jenkins
@jlduran
nuageinit: Fix the homedir variable name
789a463 
cloud-init uses homedir, not home.
@jlduran
CODEOWNERS: Add nuageinit
28c8335
@jlduran
Copy link
Member Author

jlduran commented Jul 25, 2024

Hi @bapt I have been working on nuageinit, and I expect to have a buffet of commits ready (soon-ish). Like a buffet chef, I would not mind you not liking all of the commits. But, is it something you are interested in reviewing?

In the meantime, these two commits are somewhat important:

  • One fixes CI
  • Two allows nuageinit to set the home directory to something other than /home/whatever

Thank you!

bsdimp
bsdimp approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@bsdimp bsdimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My eye says these are all good. I'll give @bapt through the weekend to comment, then I'll land it.

@bsdimp
Copy link
Member

bsdimp commented Jul 25, 2024

I almost rage committed something to disable the ci issue... So I'm glad to see it's being properly fixed here.

@jlduran
Copy link
Member Author

jlduran commented Jul 25, 2024

I almost rage committed something to disable the ci issue... So I'm glad to see it's being properly fixed here.

I felt terry bad for breaking the hard-earned streak of greens in CI (test-main).

@bapt
Copy link
Member

bapt commented Jul 25, 2024

merged thanks!

@bapt bapt closed this Jul 25, 2024
@jlduran jlduran deleted the nuageinit-fixes branch July 25, 2024 09:24
@bsdimp bsdimp added the merged label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsdimp bsdimp bsdimp approved these changes

Assignees
No one assigned
Labels
merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlduran @bsdimp @bapt