Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjkerntz.8: polish #1326

Merged
merged 7 commits into from
Jul 29, 2024
Merged

adjkerntz.8: polish #1326

merged 7 commits into from
Jul 29, 2024

Conversation

concussious
Copy link
Contributor

No description provided.

@emaste
Copy link
Member

emaste commented Jul 14, 2024

The change is good. We can also replace the x86-specifc CMOS with the MI term real-time clock

@bsdimp
Copy link
Member

bsdimp commented Jul 14, 2024

The change is good. We can also replace the x86-specifc CMOS with the MI term real-time clock

Are there other platforms where rtc is not in utc?

@concussious
Copy link
Contributor Author

concussious commented Jul 14, 2024

I hope I didn't take it too far. These are just attempts at improvements and I am happy to go back on any of these.

I got the idea to "s/the adjkerntz utility/adjkerntz/" from @grahamperrin and thought it was really nice and in the spirit of the style of the manual.

Particularly, I don't understand: were the kernel variables supposed to be marked as Pa?

concussious added a commit to concussious/freebsd-src that referenced this pull request Jul 14, 2024
+ terse docuemnt description
+ CMOS => real-time (architecture independent language)
+ kernel variables marked Pa => Va (am I understanding correctly?)
+ example commands marked Em => Ql (mdoc style)
+ the adjkerntz utility => adjkerntz (doc project style)
+ reflow some weird lines
+ if someone is here by mistake they might want ntpd, add to see also
+ align lists + tag spdx.

MFC after:	3 days
Reported by:	emaste
Pull Request:   freebsd#1326
@concussious concussious changed the title adjkerntz.8: attempt shorter document description adjkerntz.8: polish Jul 14, 2024
@bsdimp
Copy link
Member

bsdimp commented Jul 29, 2024

Does it make sense to have the registry setting that sets RTC to UTC in Windows?
If so, maybe in the future. I'm planning on landing this as is.

concussious and others added 7 commits July 29, 2024 14:06
+ real-time and rtc added to search keywords
- local dropped from search keywords
+ ntpd added to see also
+ use machine independent language

Reported by: emaste (MI language)
MFC after: 3 days
Reviewed by: imp
Pull Request: freebsd#1326
The man page states that the -d flag can be used to show the dropped
packets. But, the number of dropped input packets are always shown,
independent of the -d flag. This commit clarifies that the -d flag will
add the number of dropped output packets to the output.

MFC after: 3 days
Reviewed by: imp, Alexander Ziaee
Pull Request: freebsd#1332
If test is called as [ and one forgets to close the bracket, the error
message is currently
[: missing ]

To make it obvious that this is not something printed in brackets,
quote the closing bracket in the message, which is what everybody else
is doing:
[: missing ']'

Reviewed by: imp
Pull Request: freebsd#1346
Reviewed by: imp
Pull Request: freebsd#1349
Reviewed by: imp, emaste
Pull Request: freebsd#1351
Reviewed by: imp, emaste
Pull Request: freebsd#1351
Clarify in which formats the memberlist for groupadd/groupmod can be
accepted for '-M', '-m', or '-d' flag.

Related commit:	40ab104.

Reviewed by: imp
Pull Request: freebsd#1352
@freebsd-git freebsd-git merged commit d573295 into freebsd:main Jul 29, 2024
42 of 44 checks passed
@concussious
Copy link
Contributor Author

Does it make sense to have the registry setting that sets RTC to UTC in Windows?

That would be so cool! But:
1: I don't have Windows to test.
2: Official docs show nothing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants