Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwget: add needed firmware for AMD Raphael GPUs #1308

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

daniloegea
Copy link
Contributor

This GPU is found in Ryzen 7000 series CPUs.

For future reference, the list of firmware versions for amdgpu drivers can be found in [1].

[1] - https://docs.kernel.org/gpu/amdgpu/driver-misc.html

Notes:

Without this set of firmwares installed, loading the amdgpu driver will cause a kernel panic.

This is my GPU:

vgapci0@pci0:11:0:0:    class=0x030000 rev=0xc1 hdr=0x00 vendor=0x1002 device=0x164e subvendor=0x1043 subdevice=0x8877                                                                                                                         
    vendor     = 'Advanced Micro Devices, Inc. [AMD/ATI]'                                                                                                                                                                                      
    device     = 'Raphael'                                                                                                                                                                                                                     
    class      = display                                                                                                                                                                                                                       
    subclass   = VGA 

fwget output with this patch:

$ fwget -n
Needed firmware packages: 'wifi-firmware-iwlwifi-kmod-ax210 gpu-firmware-amd-kmod-gc-10-3-6 gpu-firmware-amd-kmod-psp-13-0-5 gpu-firmware-amd-kmod-dcn-3-1-5 gpu-firmware-amd-kmod-sdma-5-2-6 gpu-firmware-amd-kmod-vcn-3-1-2'

fwget will install the packages as expected:

[danilo@capeta ~/Sources/freebsd/usr.sbin/fwget]$ pkg info | grep amd
xf86-video-amdgpu-22.0.0_2     X.Org amdgpu display driver
[danilo@capeta ~/Sources/freebsd/usr.sbin/fwget]$ sudo fwget
Needed firmware packages: 'wifi-firmware-iwlwifi-kmod-ax210 gpu-firmware-amd-kmod-gc-10-3-6 gpu-firmware-amd-kmod-psp-13-0-5 gpu-firmware-amd-kmod-dcn-3-1-5 gpu-firmware-amd-kmod-sdma-5-2-6 gpu-firmware-amd-kmod-vcn-3-1-2'
[danilo@capeta ~/Sources/freebsd/usr.sbin/fwget]$ pkg info | grep amd
gpu-firmware-amd-kmod-dcn-3-1-5-20230625_2 Firmware modules for dcn_3_1_5 AMD GPUs
gpu-firmware-amd-kmod-gc-10-3-6-20230625_2 Firmware modules for gc_10_3_6 AMD GPUs
gpu-firmware-amd-kmod-psp-13-0-5-20230625_2 Firmware modules for psp_13_0_5 AMD GPUs
gpu-firmware-amd-kmod-sdma-5-2-6-20230625_2 Firmware modules for sdma_5_2_6 AMD GPUs
gpu-firmware-amd-kmod-vcn-3-1-2-20230625_2 Firmware modules for vcn_3_1_2 AMD GPUs
xf86-video-amdgpu-22.0.0_2     X.Org amdgpu display driver
[danilo@capeta ~/Sources/freebsd/usr.sbin/fwget]$

@chrislongros
Copy link

chrislongros commented Jun 30, 2024

So the kernel panic was only the result of non installed firmware?
Does this PR completely resolve the issue? Wish I could test it soon

@bsdimp
Copy link
Member

bsdimp commented Jun 30, 2024

Can you add that url to the top of thepci_video_amd() function as a sign post for others?

Too bad that table isn't in a form that we could use to generate this file...

@daniloegea
Copy link
Contributor Author

@chrislongros yes, but it's not clear to me why it's panic'ing. I realized that when all the firmwares it expects for my GPU are loaded it wouldn't panic. But as you saw in my bug report, all I get now is a black screen and the system hangs...

@bsdimp sure, I'll do that. Thanks.

Copy link
Member

@bsdimp bsdimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@bsdimp
Copy link
Member

bsdimp commented Jul 1, 2024

@evadot Any issues with this? Looks good to me and ready to go.

@bsdimp bsdimp added the ready label Jul 1, 2024
@evadot
Copy link
Contributor

evadot commented Jul 1, 2024

LGTM too.

This GPU is found in Ryzen 7000 series CPUs.

For future reference, the list of firmware versions for amdgpu drivers
can be found in [1].

[1] - https://docs.kernel.org/gpu/amdgpu/driver-misc.html

Reviewed by: imp, Christos Longros
Pull Request: freebsd#1308
@freebsd-git freebsd-git merged commit 12545b8 into freebsd:main Jul 7, 2024
7 of 9 checks passed
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Oct 30, 2024
This GPU is found in Ryzen 7000 series CPUs.

For future reference, the list of firmware versions for amdgpu drivers
can be found in [1].

[1] - https://docs.kernel.org/gpu/amdgpu/driver-misc.html

Reviewed by: imp, Christos Longros
Pull Request: freebsd/freebsd-src#1308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants