Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow customizing passing grade #382

Merged
merged 5 commits into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/quiz/quiz.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const QuizDefault = () => {
correct: "Correct",
incorrect: "Incorrect",
},
passingGrade: 100,
});

return <Quiz questions={questions} />;
Expand Down Expand Up @@ -93,6 +94,7 @@ const QuizWithValidation = () => {
correct: "Correct",
incorrect: "Incorrect",
},
passingGrade: 100,
});
const [disabled, setDisabled] = useState(false);

Expand Down
1 change: 1 addition & 0 deletions src/quiz/quiz.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const ControlledQuiz = ({ disabled, required }: Partial<QuizProps<number>>) => {
correct: "Correct",
incorrect: "Incorrect",
},
passingGrade: 80,
});

return <Quiz questions={questions} disabled={disabled} required={required} />;
Expand Down
59 changes: 57 additions & 2 deletions src/quiz/use-quiz.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ describe("useQuiz", () => {
},
],
validationMessages,
passingGrade: 100,
}),
);

Expand Down Expand Up @@ -89,6 +90,7 @@ describe("useQuiz", () => {
},
],
validationMessages,
passingGrade: 100,
}),
);

Expand Down Expand Up @@ -122,6 +124,7 @@ describe("useQuiz", () => {
},
],
validationMessages,
passingGrade: 100,
}),
);

Expand Down Expand Up @@ -158,19 +161,26 @@ describe("useQuiz", () => {
},
],
validationMessages,
passingGrade: 100,
}),
);

expect(result.current.validated).toBe(false);
expect(result.current.correctAnswerCount).toBeUndefined();
expect(result.current.grade).toBeUndefined();

act(() => {
result.current.validateAnswers();
});

expect(result.current.questions[0].validation?.message).toBe("Correct");
expect(result.current.questions[1].validation?.message).toBe("Incorrect");
expect(result.current.correctAnswerCount).toBe(1);
expect(result.current.grade).toBe(50);
expect(result.current.validated).toBe(true);
});

it("should call the `onSuccess` function if all answers are correct", () => {
it("should call the `onSuccess` function if the quiz results meet the passing grade", () => {
const onSuccess = jest.fn();
const onFailure = jest.fn();

Expand Down Expand Up @@ -201,6 +211,7 @@ describe("useQuiz", () => {
validationMessages,
onSuccess,
onFailure,
passingGrade: 100,
}),
);

Expand All @@ -212,7 +223,7 @@ describe("useQuiz", () => {
expect(onFailure).toHaveBeenCalledTimes(0);
});

it("should call the `onFailure` function if not all answers are correct", () => {
it("should call the `onFailure` function if the quiz results don't meet the passing grade", () => {
const onSuccess = jest.fn();
const onFailure = jest.fn();

Expand Down Expand Up @@ -243,6 +254,7 @@ describe("useQuiz", () => {
validationMessages,
onSuccess,
onFailure,
passingGrade: 100,
}),
);

Expand All @@ -253,4 +265,47 @@ describe("useQuiz", () => {
expect(onSuccess).toHaveBeenCalledTimes(0);
expect(onFailure).toHaveBeenCalledTimes(1);
});

it("should register the passing grade correctly", () => {
const onSuccess = jest.fn();
const onFailure = jest.fn();

const { result } = renderHook(() =>
useQuiz({
initialQuestions: [
{
question: "Lorem ipsum dolor sit amet",
answers: [
{ label: "Option 1", value: 1 },
{ label: "Option 2", value: 2 },
{ label: "Option 3", value: 3 },
],
selectedAnswer: 1,
correctAnswer: 2,
},
{
question: "Consectetur adipiscing elit",
answers: [
{ label: "Option 1", value: 1 },
{ label: "Option 2", value: 2 },
{ label: "Option 3", value: 3 },
],
selectedAnswer: 3,
correctAnswer: 3,
},
],
validationMessages,
onSuccess,
onFailure,
passingGrade: 50,
}),
);

act(() => {
result.current.validateAnswers();
});

expect(onSuccess).toHaveBeenCalledTimes(1);
expect(onFailure).toHaveBeenCalledTimes(0);
});
});
42 changes: 36 additions & 6 deletions src/quiz/use-quiz.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,47 @@ import { useState } from "react";

import { type Question } from "./types";

type InitialQuestion<AnswerT extends number | string> = Omit<
Question<AnswerT>,
"onChange"
>;

type ReturnedQuestion<AnswerT extends number | string> = Question<AnswerT> & {
onChange: (selectedAnswer: AnswerT) => void;
};

interface Props<AnswerT extends number | string> {
initialQuestions: Question<AnswerT>[];
initialQuestions: InitialQuestion<AnswerT>[];
validationMessages: {
correct: string;
incorrect: string;
};
passingGrade: number;
onSuccess?: () => void;
onFailure?: () => void;
}

type ValidationData =
| { validated: true; grade: number; correctAnswerCount: number }
| { validated: false; grade?: never; correctAnswerCount?: never };

type UseQuizReturnType<AnswerT extends number | string> = ValidationData & {
questions: ReturnedQuestion<AnswerT>[];
validateAnswers: () => void;
};

export const useQuiz = <AnswerT extends number | string>({
initialQuestions,
validationMessages,
onSuccess,
onFailure,
}: Props<AnswerT>) => {
passingGrade,
}: Props<AnswerT>): UseQuizReturnType<AnswerT> => {
const [questions, setQuestions] =
useState<Question<AnswerT>[]>(initialQuestions);
const [correctAnswerCount, setCorrectAnswerCount] = useState(0);
const [validation, setValidation] = useState<ValidationData>({
validated: false,
});

const questionsWithChangeHandling = questions.map((question, index) => ({
...question,
Expand Down Expand Up @@ -58,9 +80,17 @@ export const useQuiz = <AnswerT extends number | string>({
({ validation }) => validation?.state === "correct",
).length;

setCorrectAnswerCount(correctCount);
const grade = parseFloat(
((correctCount / initialQuestions.length) * 100).toFixed(2),
);

setValidation({
validated: true,
grade,
correctAnswerCount: correctCount,
});

if (correctCount === initialQuestions.length) {
if (grade >= passingGrade) {
onSuccess && onSuccess();
} else {
onFailure && onFailure();
Expand All @@ -73,6 +103,6 @@ export const useQuiz = <AnswerT extends number | string>({
return {
questions: questionsWithChangeHandling,
validateAnswers,
correctAnswerCount,
...validation,
};
};