Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move storybook config files to use typescript #374

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: move storybook config files to use typescript #374

wants to merge 2 commits into from

Conversation

shootermv
Copy link

Checklist:

Closes #369

@shootermv shootermv requested a review from a team as a code owner October 13, 2024 08:45
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from 5ed3484 to 594ced6 Compare October 20, 2024 14:07
huyenltnguyen
huyenltnguyen reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

I'm afraid renaming the files is not enough. I pulled the branch down and got some TS errors in main.ts, manager.ts, and theme.ts.

Those TS errors should be reported when the typecheck command runs, but they currently aren't. So there should be some changes to the tsconfig file as well.

@huyenltnguyen huyenltnguyen added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Oct 24, 2024
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from 594ced6 to 1b6b60e Compare October 24, 2024 16:58
@socket-security Socket Security
Copy link

socket-security bot commented Oct 24, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 2.26 MB types

View full report↗︎

@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from c6b794f to cba6c5a Compare October 24, 2024 18:00
@shootermv
Copy link
Author

I added some missing packages Which seem to resolve ts errors (hope u will have time to review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyenltnguyen huyenltnguyen huyenltnguyen left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Storybook config files to TypeScript
2 participants
@shootermv @huyenltnguyen