-
-
Notifications
You must be signed in to change notification settings - Fork 38k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use ast-based helpers #53125
feat: use ast-based helpers #53125
Conversation
👀 Review this PR in a CodeSee Review Map |
44b045d
to
9ed87eb
Compare
247c976
to
0f91752
Compare
I'm not sure why the Italian and Portuguese are failing here, but not in main. The next challenge (step 37) is missing, but that's true for main, too. I'll dig into that, but otherwise this should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, but I thought we wanted to move away from using the fake filesystem because it was messing up tests?
No, not really. It's more that we want to avoid nesting a test runner inside our own test runner. We didn't need to do it and it make it hard to debug failing tests. As for why I used it here: it seemed easier than figuring out how to escape the code string. If there's a nice way to do that, we can drop the FS stuff. |
e161453
to
a5d5ef5
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@freecodecamp/[email protected] |
Ooof, more regex issues. @ShaunSHamilton if you've got any ideas, let me know, otherwise I'll have another go. |
@ojeytonwilliams Why is just the |
I've not dug into it, but they must have different solutions since they're not syncing properly at the moment. Assuming that's correct, those solutions are confusing the regex, but are probably valid python. |
This should fix the failing test: freeCodeCamp/curriculum-helpers#148 Here is else:
key_char = key[key_index % len(key)] Here is else:
key_char = key[key_index % len(key)] |
b0f36ed
to
31dc9e5
Compare
chore: bump curriculum-helpers to 2.3.0
31dc9e5
to
1d4d785
Compare
Checklist:
main
branch of freeCodeCamp.This makes use of the new tools for evaluating python code, recently added to https://github.com/freeCodeCamp/curriculum-helpers/ and documented
here
I added a sample curriculum test and there are a bunch of tests of the code itself in the curriculum-helpers. They demonstrate multiple ways to use the library.