Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency express to v4.19.2 [security] #594

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 26, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 4.18.3 -> 4.19.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with [email protected], we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location


Release Notes

expressjs/express (express)

v4.19.2

Compare Source

==========

  • Improved fix for open redirect allow list bypass

v4.19.1

Compare Source

==========

  • Allow passing non-strings to res.location with new encoding handling checks

v4.19.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the renovate label Mar 26, 2024
Copy link

socket-security bot commented Mar 26, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] environment, filesystem, unsafe +21 1.15 MB nicolo-ribaudo
npm/[email protected] None 0 27.5 kB domenic
npm/[email protected] None 0 67.3 kB nathanboktae
npm/[email protected] None 0 6.39 kB jaredhanson
npm/[email protected] Transitive: environment, eval, filesystem, network, unsafe +15 2.87 MB mingchuno
npm/[email protected] None +1 30.2 kB dougwilson
npm/[email protected] environment +4 112 kB dougwilson
npm/[email protected] Transitive: environment, eval, filesystem, network, unsafe +69 2.1 MB
npm/[email protected] None 0 1.34 MB juliankrispel
npm/[email protected] Transitive: network +13 72.5 kB vdemedes
npm/[email protected] None +14 400 kB evanhahn
npm/[email protected] eval, filesystem, network, shell, unsafe Transitive: environment +58 10.2 MB domenic
npm/[email protected] None 0 4.35 MB ichernev
npm/[email protected] eval +4 90.1 kB dougwilson
npm/[email protected] Transitive: network +5 196 kB jaredhanson
npm/[email protected] network +2 75.2 kB jaredhanson
npm/[email protected] environment, eval, filesystem +33 5.28 MB pug-bot

🚮 Removed packages: npm/@babel/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 5db0c9a to f4b615d Compare March 26, 2024 03:30
@renovate renovate bot merged commit 8a76179 into main Mar 26, 2024
2 checks passed
@renovate renovate bot deleted the renovate/npm-express-vulnerability branch March 26, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants