feat: permutateRegex #156
Open
feat: permutateRegex #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Yes this would be so helpful for saving me on some of the regex I've written. |
ojeytonwilliams
requested changes
Feb 28, 2024
Comment on lines
+18
to
+22
| const source1 = `titleInput\\.value\\s*(?:!==|!=)\\s*currentTask\\.title`; | ||
| const regex1 = /dateInput\.value\s*(?:!==|!=)\s*currentTask\.date/; | ||
| const source2 = `descriptionInput\\.value\\s*(?:!==|!=)\\s*currentTask\\.description`; | ||
|
|
||
| permutateRegex([source1, regex1, source2]).source === new RegExp(/(?:titleInput\.value\s*(?:!==|!=)\s*currentTask\.title\s*\|\|\s*dateInput\.value\s*(?:!==|!=)\s*currentTask\.date\s*\|\|\s*descriptionInput\.value\s*(?:!==|!=)\s*currentTask\.description|dateInput\.value\s*(?:!==|!=)\s*currentTask\.date\s*\|\|\s*titleInput\.value\s*(?:!==|!=)\s*currentTask\.title\s*\|\|\s*descriptionInput\.value\s*(?:!==|!=)\s*currentTask\.description|descriptionInput\.value\s*(?:!==|!=)\s*currentTask\.description\s*\|\|\s*titleInput\.value\s*(?:!==|!=)\s*currentTask\.title\s*\|\|\s*dateInput\.value\s*(?:!==|!=)\s*currentTask\.date|titleInput\.value\s*(?:!==|!=)\s*currentTask\.title\s*\|\|\s*descriptionInput\.value\s*(?:!==|!=)\s*currentTask\.description\s*\|\|\s*dateInput\.value\s*(?:!==|!=)\s*currentTask\.date|dateInput\.value\s*(?:!==|!=)\s*currentTask\.date\s*\|\|\s*descriptionInput\.value\s*(?:!==|!=)\s*currentTask\.description\s*\|\|\s*titleInput\.value\s*(?:!==|!=)\s*currentTask\.title|descriptionInput\.value\s*(?:!==|!=)\s*currentTask\.description\s*\|\|\s*dateInput\.value\s*(?:!==|!=)\s*currentTask\.date\s*\|\|\s*titleInput\.value\s*(?:!==|!=)\s*currentTask\.title)/).source; |
There was a problem hiding this comment.
How about smaller sources? It's quite tricky to see what the functions actually doing with these. Unless I'm missing something permutateRegex(['a', \b\, 'c']) should capture everything we care about.
Also, could you document the separator? It wasn't obvious to me what that did until I looked into the source.
| expect(regex.test("b||c||a")).toBe(true); | ||
| expect(regex.test("c||a||b")).toBe(true); | ||
| expect(regex.test("c||b||a")).toBe(true); | ||
| expect(regex.source).not.toEqual("(?:)"); |
There was a problem hiding this comment.
Suggested change
| expect(regex.source).not.toEqual("(?:)"); |
Do we need this? The next test checks what it doesn't match, after all.
Comment on lines
+188
to
+189
|
|
||
| console.log(regex); |
There was a problem hiding this comment.
Suggested change
| console.log(regex); |
| function _permutations(permutation: (string | RegExp)[]) { | ||
| const permutations: (string | RegExp)[][] = []; | ||
|
|
||
| function permute(array: (string | RegExp)[], length: number) { |
There was a problem hiding this comment.
Suggested change
| function permute(array: (string | RegExp)[], length: number) { | |
| // Heap's algorithm | |
| function permute(array: (string | RegExp)[], length: number) { |
Just so people know what they're looking at.
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)a,bandc, which checks code written asa || b || c, it should match botha || b || candb || a || c, and any other permutation.elementsSeparatoris a bit arbitrarily picked...Capturing groups in individual regex
("|')thing\1,(?<m>"|")thing\k<m>. It'd be good to support it.