Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a new SQL question #688

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Added a new SQL question #688

merged 3 commits into from
Oct 1, 2023

Conversation

npxpatel
Copy link
Contributor

@npxpatel npxpatel commented Sep 30, 2023 •
edited
Loading

Checklist:

jdwilkin4
jdwilkin4 requested changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please review the requested changes.
Once those changes have been implemented, then we can merge your PR into main. 👍

src/data/sql-quiz.ts Outdated Show resolved Hide resolved
@npxpatel
Copy link
Contributor Author

npxpatel commented Oct 1, 2023

Changes made, thanks for the feedback!

jdwilkin4
jdwilkin4 approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first contribution to our repository. 🎉
We look forward to future contributions. 👍

@jdwilkin4 jdwilkin4 merged commit 799c593 into freeCodeCamp:main Oct 1, 2023
2 checks passed
@npxpatel npxpatel deleted the patch-1 branch October 3, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npxpatel @jdwilkin4