refactor: NRF Server & processor #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @KunLee76 Please use Thanks! |
andy89923
reviewed
Jun 4, 2024
Comment on lines
+20
to
+24
| type HandlerResponse struct { | ||
| Status int | ||
| Headers map[string][]string | ||
| Body interface{} | ||
| } |
There was a problem hiding this comment.
I think we don't need this
ianchen0119
reviewed
Jun 7, 2024
tim1207
reviewed
Jun 11, 2024
tim1207
reviewed
Jun 11, 2024
|
Remember to remove unused code. |
KunLee76
force-pushed
the
feat/r17
branch
2 times, most recently
from
d71cf91
to
e26359c
Compare
andy89923
requested changes
Jun 13, 2024
internal/sbi/server.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (s *Server) buildAndSendHttpResponse( |
There was a problem hiding this comment.
I think we don't use this.
internal/sbi/server.go
Outdated
| } | ||
| } | ||
|
|
||
| func buildHttpResponseHeader(gc *gin.Context, rsp *httpwrapper.Response) { |
There was a problem hiding this comment.
I think we don't use this.
| @@ -30,6 +30,7 @@ const ( | |||
| NrfSbiDefaultScheme = "https" | |||
| NrfNfmResUriPrefix = "/nnrf-nfm/v1" | |||
| NrfDiscResUriPrefix = "/nnrf-disc/v1" | |||
| NrfAccTokenResUriPrefix = "" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server
api_{SVC}.goProcessor
processor/processor.goaccesstoken.go,nfdiscovery.go&nfmanagement.go