refactor(runners): allow for custom runners #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikaverpil
force-pushed
the
runners-refactor
branch
9 times, most recently
from
47d957b
to
130a049
Compare
fredrikaverpil
commented
Sep 21, 2024
fredrikaverpil
commented
Sep 21, 2024
fredrikaverpil
force-pushed
the
runners-refactor
branch
from
cc04c23
to
bed433e
Compare
fredrikaverpil
force-pushed
the
runners-refactor
branch
3 times, most recently
from
9ef5aed
to
c244b7a
Compare
fredrikaverpil
force-pushed
the
runners-refactor
branch
4 times, most recently
from
445b442
to
c282a1a
Compare
fredrikaverpil
force-pushed
the
runners-refactor
branch
2 times, most recently
from
569ee84
to
38433a8
Compare
fredrikaverpil
force-pushed
the
runners-refactor
branch
from
38433a8
to
832f76c
Compare
|
I'm going to close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Bring your own test runner as discussed in...
This PR will make
go testandgotestsuminto first-class citizen test runners, showcasing how you can provide your own (via opts) by looking at how these are implemented.What?
Notes
I'm very much trying out the feel of a bunch of refactorings in this PR. I might want to start over in a fresh PR once I have something that feels good. I'm not entirely happy as it stands and I might close this PR just because nobody right now seems to need this anyway...
But it has been a good excercise in figuring out how to support two levels of configuring test runners; one easy level where you just set the runner and the args in your opts - and one deeper level where you can potentially supply custom logic.