Add Analogue Pocket pack. #857
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotelvictorcharlie
force-pushed
the
add-analogue-pocket-pack
branch
from
61796db to
1bd13c6
Compare
hotelvictorcharlie
force-pushed
the
add-analogue-pocket-pack
branch
from
faffe2a to
341c69d
Compare
hotelvictorcharlie
force-pushed
the
add-analogue-pocket-pack
branch
from
978bb92 to
362fe00
Compare
hotelvictorcharlie
force-pushed
the
add-analogue-pocket-pack
branch
from
362fe00 to
3e5f2b5
Compare
hotelvictorcharlie
force-pushed
the
add-analogue-pocket-pack
branch
from
b16e548 to
e099ffb
Compare
hotelvictorcharlie
force-pushed
the
add-analogue-pocket-pack
branch
from
8556742 to
98e5c44
Compare
hotelvictorcharlie
force-pushed
the
add-analogue-pocket-pack
branch
from
64c7a75 to
646ac4c
Compare
hotelvictorcharlie
force-pushed
the
add-analogue-pocket-pack
branch
from
fe50e68 to
876f5ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm leaving this as a draft PR for now, because we need #846, #854, and #862 to be merged first (in order to get the standalone packs that we need to reference).
We also need #855 to be merged in order to make a few of the hacks/translations/homebrews compatible with the Pocket's SNES core.The last sentence is no longer relevant as the SNES core has support for SMC headers now (although that PR is still a good idea and should be merged).The Neo Geo core requires a
.bakfile and all of the cores require.jsonfiles, so I removed those extensions from the banned suffixes list.Side note: The
Darksoft Neo Geopack's files are all located inside agames/subdirectory. I'm not sure why that's there, but it shouldn't exist on the Pocket. So you're supposed to copyDarksoft Neo Geo/games/*intoAnalogue Pocket/Assets/ng/common/. I'm not sure how to specify/explain that in the placeholder, unless we can just update theDarksoft Neo Geopack to do away with thegames/subdirectory entirely.I strongly suggest doing a "Squash and Merge" on this PR due to the large number of commits.