Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: add cache variables for BUILD_SHARED_LIBS & VVDEC_LIBRARY_ONLY #207

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

K-os
Copy link
Collaborator

@K-os K-os commented Oct 15, 2024

closes #202

@K-os K-os requested a review from lehmann-c October 15, 2024 10:01
@K-os K-os marked this pull request as ready for review October 15, 2024 11:33
@adamjw24
Copy link
Member

Same issue here, what about make test?

@K-os
Copy link
Collaborator Author

K-os commented Oct 15, 2024

see vvenc #422

@K-os K-os force-pushed the cmake_cache_BUILD_SHARED_LIBS branch 2 times, most recently from d5ca6c3 to f564418 Compare October 15, 2024 12:51
@K-os K-os marked this pull request as draft October 15, 2024 13:06
@K-os K-os force-pushed the cmake_cache_BUILD_SHARED_LIBS branch from f564418 to 3b78349 Compare October 15, 2024 15:17
@K-os K-os marked this pull request as ready for review October 15, 2024 15:18
@K-os
Copy link
Collaborator Author

K-os commented Oct 15, 2024

We do output a warning now that the test suite will not be able to run, when enabling VVDEC_LIBRARY_ONLY.

@adamjw24 adamjw24 merged commit 3c9c671 into fraunhoferhhi:master Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add 2 bool cmake entries for cmake-gui
3 participants