Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mainly build system fixes #177

Merged
merged 2 commits into from
May 23, 2024
Merged

mainly build system fixes #177

merged 2 commits into from
May 23, 2024

Conversation

K-os
Copy link
Collaborator

@K-os K-os commented May 22, 2024

- cleanup cmake toolchain files
- add ubuntu armv7 toolchain file (gh: fraunhoferhhi#175)
- fix build with TARGET_SIMD_X86 disabled (gh: fraunhoferhhi#175)
- impove target architecture detection heuristics
- don't build avx2 files, when not needed
- fix windows for arm64 builds
@adamjw24 adamjw24 merged commit ffe3010 into fraunhoferhhi:master May 23, 2024
7 checks passed
@shijunz
Copy link

shijunz commented Jul 15, 2024

  • fix windows for arm64 builds (untested)
    I am trying to build the windows-arm64 version now. I want to know how to configure the cmake cmd for the windows arm64? could you help me? I do not think it is easy way to do ,

I think the most of work should be about the simde modules? or someone use the simde module for windows arm64 before?

thanks in advances.

@K-os
Copy link
Collaborator Author

K-os commented Jul 15, 2024

It does compile with SIMD-Everywhere enabled (the default) for ARM64 using Visual Studio, but since we don't have an ARM based windows machine, it's untested.

Feel free to give it a try and report your findings.

@shijunz
Copy link

shijunz commented Jul 16, 2024

It does compile with SIMD-Everywhere enabled (the default) for ARM64 using Visual Studio, but since we don't have an ARM based windows machine, it's untested.

Feel free to give it a try and report your findings.

yes, I have two ARM based windows machine, could you share me the detail? how to build windows arm64? I am happy to test it.

@K-os
Copy link
Collaborator Author

K-os commented Jul 19, 2024

Using the top-level Makefile add the parameter msvc-arch=arm64 to your make call, or if you are using CMake directly add the parameter -A arm64 to your cmake commandline.

A good first test would be to run the test-suite for example:

make msvc-arch=arm64  enable-bitstream-download=1 release
make test

or like this:

cmake -A arm64 -B build/win_arm64 -DVVDEC_ENABLE_BITSTREAM_DOWNLOAD=ON
cmake --build build/win_arm64
cmake --build build/win_arm64 -t test

@K-os K-os deleted the build_fixes branch October 2, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants