Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in MSVC Debug build when use SSE 4.1 due uninitialized variables. #176

Merged
merged 1 commit into from
May 15, 2024

Conversation

Aleksoid1978
Copy link
Contributor

No description provided.

@Aleksoid1978
Copy link
Contributor Author

Aleksoid1978 commented May 12, 2024

Shouldn't we always initialize __m256i and __m128i variables, and not just in Debug mode?
There, in the code, reading from an uninitialized variable occurs.

Using an uninitialized variable - this is a potential UB.

@adamjw24
Copy link
Member

If you look into the code, you can see all the variables are initialized properly, no UB will happen. At least not with the block sizes possible in VVC. For Debug Mode I know MSVC is oversensitive sometimes.

@adamjw24 adamjw24 merged commit 531b671 into fraunhoferhhi:master May 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants