fix: stop processing in create_usage_records job if it took more than 15min #2260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In create_usage_records we process the usage of sites synchronously in a batch size of 200.
we hold lock on the record at the time of submission of
usage record
.press/press/press/doctype/usage_record/usage_record.py
Lines 64 to 68 in 2f435f8
When there is some wait for lock on a record and it delay the overall job, it can exceed 15 minute. Meanwhile, next job started and start processing same record, hence more errors.
Multiple instance of same job running
If we can stop process further records after 15 minute, it can reduce the errors.