Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssh): Fix condition in generate_ssh_keys #2230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Oct 17, 2024

The ssh_certificate_authority field could be either a non-empty string, an empty string, or None. The "empty string" case was not checked by the is None condition. It took the liberty to also modernize the frappe.get_value call to frappe.db.get_single_value.

image

@cogk cogk requested a review from 18alantom as a code owner October 17, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants