Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: provision to disable frappe.io auth dependency #1750

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

fix: provision to disable frappe.io auth dependency #1750

wants to merge 12 commits into from

Conversation

saurabh6790
Copy link
Member

No description provided.

@phot0n phot0n mentioned this pull request May 7, 2024
Closed
@phot0n
Copy link

phot0n commented May 20, 2024 •
edited
Loading

Don't raise exception if the url is not found instead of adding another field?
Better UX wise with a new field :p

Also all this logic which connects and does stuff on frappe.io and erpnext.com should probably be moved to another app?

@saurabh6790 saurabh6790 force-pushed the frappe-io-auth branch 2 times, most recently from 34170c7 to fca8687 Compare June 26, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadrak98 shadrak98 shadrak98 approved these changes

@rutwikhdev rutwikhdev Awaiting requested review from rutwikhdev

@BreadGenie BreadGenie Awaiting requested review from BreadGenie BreadGenie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saurabh6790 @phot0n @shadrak98 @tanmoysrt