Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using google docs viewer to render pdf #1045

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

pateljannat
Copy link
Collaborator

  1. PDF rendering doesn't work on mobile as mobile browsers don't support the same.
  2. This is an experiment to see if using google docs PDF viewer makes the content work in mobile.

Copy link

cypress bot commented Oct 8, 2024

lms    Run #712

Run Properties:  status check passed Passed #712  •  git commit 940cba1741 ℹ️: Merge 2e4cf02737d221c6e5efb28b75f3f9669d8c5c55 into 438e9e1c4701c344d314c35d72ab...
Project lms
Run status status check passed Passed #712
Run duration 00m 37s
Commit git commit 940cba1741 ℹ️: Merge 2e4cf02737d221c6e5efb28b75f3f9669d8c5c55 into 438e9e1c4701c344d314c35d72ab...
Committer Jannat Patel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1

@pateljannat pateljannat merged commit 9b9af02 into frappe:develop Oct 8, 2024
5 checks passed
@pateljannat pateljannat deleted the issues-37 branch October 8, 2024 07:24
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants