fix: simplify test connection query

frappe · Oct 9, 2023 · 1a13be9 · 1a13be9
1 parent f4313b9
commit 1a13be9
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/insights/insights/doctype/insights_data_source/sources/base_database.py b/insights/insights/doctype/insights_data_source/sources/base_database.py
@@ -33,7 +33,8 @@ def __init__(self):
  self.table_factory = None
 
  def test_connection(self):
- return self.execute_query("SELECT 1")
+ with self.connect() as connection:
+ connection.execute(text("SELECT 1"))
 
  def connect(self):
  try: