fix: perm errors during expense claim creation for ESS users #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are passing. Failed to upload coverage data. Merging |
ruchamahabal
added a commit
that referenced
this pull request
Aug 16, 2023
…#794) (#795) Co-authored-by: Rucha Mahabal <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
## [14.10.1](v14.10.0...v14.10.1) (2023-08-16) ### Bug Fixes * **Bank Reco Tool:** migrate `amount_condition` to `exact_match` (backport [#769](#769)) ([#778](#778)) ([900fdee](900fdee)) * don't refresh toolbar after salary slip creation since `reload_doc` is already called ([2e944d2](2e944d2)) * **Payroll Entry:** remove unnecessary refresh calls ([ea60708](ea60708)) * **Payroll Entry:** unsubscribe before resubscribing for realtime events ([d553bc7](d553bc7)) * perm errors during expense claim creation for ESS users (backport [#794](#794)) ([#795](#795)) ([a13ee09](a13ee09)) * submit button not visible when Payroll Entry status is Failed ([7ad8f1b](7ad8f1b)) * Update work Anniversary Reminder email (backport [#740](#740)) ([#779](#779)) ([43ae8c3](43ae8c3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grant read access for Company & Expense Claim Type to ESS user: