Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grant read access for Employee Checkin to ESS user #708

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Jul 20, 2023

ESS users should have read access to Employee Checkin. Employee role has it too.

no-docs

@ruchamahabal ruchamahabal marked this pull request as draft July 20, 2023 11:24
@ruchamahabal ruchamahabal marked this pull request as ready for review July 20, 2023 11:47
@ruchamahabal ruchamahabal merged commit 223bc88 into frappe:develop Jul 20, 2023
6 of 7 checks passed
mergify bot pushed a commit that referenced this pull request Jul 20, 2023
(cherry picked from commit 223bc88)

# Conflicts:
#	hrms/patches.txt
ruchamahabal added a commit that referenced this pull request Jul 20, 2023
frappe-pr-bot pushed a commit that referenced this pull request Jul 21, 2023
# [14.7.0](v14.6.2...v14.7.0) (2023-07-21)

### Bug Fixes

* don't consider default shift in overlapping period if curr shift is found ([31eb1b7](31eb1b7))
* mark employees absent 1 day after `actual_end` time instead of `actual_start` ([e567fbb](e567fbb))
* validate shift type is same for marking employee absent ([4caf703](4caf703))

### Features

* grant read access for Employee Checkin to ESS user (backport [#708](#708)) ([#710](#710)) ([942a55a](942a55a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant