Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dont run tests on every push #700

Merged
merged 1 commit into from
Jul 19, 2023
Merged

ci: dont run tests on every push #700

merged 1 commit into from
Jul 19, 2023

Conversation

ankush
Copy link
Member

@ankush ankush commented Jul 19, 2023

Rationale:

  • PRs already run test by merging PR in develop branch (this is how
    github works)
  • Running tests on practically identical code JUST after merge rarely
    helps. This has found failures from conflicting changes maybe once or
    twice a year. That much CO2 is not justified.
  • It already runs once a day so you have good enough granuarilty to
    bisect if required.

Rationale:
- PRs already run test by merging PR in develop branch (this is how
  github works)
- Running tests on practically identical code JUST after merge rarely
  helps. This has found failures from conflicting changes maybe once or
  twice a year. That much CO2 is not justified.
- It already runs once a day so you have good enough granuarilty to
  bisect if required.
@ankush ankush merged commit 5f7d49e into frappe:develop Jul 19, 2023
3 of 5 checks passed
@ankush ankush deleted the save_co2 branch July 19, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant