Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow creating draft attendance requests for future dates #2255

Closed

Conversation

iamejaaz
Copy link
Contributor

@iamejaaz iamejaaz commented Oct 5, 2024

Closes #1957

Please provide enough information so that others can review your pull request:

You can find information here #1957

Explain the details for making this change. What existing problem does the pull request solve?

It will allow users to make attendance requests for future dates.

Screenshots/GIFs

image

Copy link
Member

@krantheman krantheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow semantic commits and format according to linter.

hrms/hr/utils.py Outdated Show resolved Hide resolved
@iamejaaz
Copy link
Contributor Author

Please follow semantic commits and format according to linter.

Done making changes as requested, and followed the semantic commit and format according to linter formatting for new commits, but checks are failing for old commits.

@krantheman
Copy link
Member

Done making changes as requested, and followed the semantic commit and format according to linter formatting for new commits, but checks are failing for old commits.

Thanks for the quick response! You will have to amend that commit as well for the CI to pass.

krantheman and others added 27 commits October 15, 2024 15:18
@iamejaaz iamejaaz force-pushed the attendance-request-future-date branch from 377c441 to 07dd28c Compare October 15, 2024 18:01
@iamejaaz
Copy link
Contributor Author

Done making changes as requested, and followed the semantic commit and format according to linter formatting for new commits, but checks are failing for old commits.

Thanks for the quick response! You will have to amend that commit as well for the CI to pass.

Thanks for the link and guidance, but something unexpected happened, so I'm closing this PR and creating a new one. #2292

@iamejaaz iamejaaz closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attendance Request for Future date
5 participants