fix: allow optional tax component addition & removal (backport #814) (#…

…815) Co-authored-by: Rucha Mahabal <[email protected]>
frappe · Aug 23, 2023 · 186e882 · 186e882
1 parent b931037
commit 186e882
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/hrms/payroll/doctype/salary_slip/salary_slip.py b/hrms/payroll/doctype/salary_slip/salary_slip.py
@@ -1148,7 +1148,13 @@ def add_tax_components(self):
  else:
  self.other_deduction_components.append(d.salary_component)
 
+ # consider manually added tax component
  if not tax_components:
+ tax_components = [
+ d.salary_component for d in self.get("deductions") if d.variable_based_on_taxable_salary
+ ]
+
+ if self.is_new() and not tax_components:
  tax_components = self.get_tax_components()
  frappe.msgprint(
  _(