Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get article category and sub category from query params #1952

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

RitvikSardana
Copy link
Member

@RitvikSardana RitvikSardana commented Aug 30, 2024

Issue:
While navigating to article page from article sub category, the article component gets async data in the breadcrumb which causes the following issue
Screenshot 2024-08-30 at 11 48 48 AM

Reason:
In breadcrumbs the route is coming asynchronously, hence the error.

Fix:
Get article's category and sub category from query params.

@RitvikSardana RitvikSardana changed the title fix: get article cat and sub cat from query params fix: get article category and sub category from query params Aug 30, 2024
@RitvikSardana RitvikSardana merged commit e8e7473 into frappe:develop Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant