Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: re-enable workspaces #278

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

blaggacao
Copy link
Contributor

f9c8db3

The original "chore" commit didn't specify a specific reason.

On the other hand, the lack of a proper workspace configuration breaks the Frappix build of Gameplan.

This PR re-instates the workspaces and heals Frappix builds of Gameplan

@blaggacao blaggacao force-pushed the revert/re-enable-workspaces branch 2 times, most recently from f36cc1c to 9a7b551 Compare March 23, 2024 15:48
Copy link

cypress bot commented Mar 23, 2024

5 failed tests on run #248 ↗︎

5 1 0 0 Flakiness 0

Details:

Merge 41b5936 into d357258...
Project: gameplan Commit: 2b8d445c85 ℹ️
Status: Failed Duration: 02:40 💡
Started: Jul 23, 2024 1:43 AM Ended: Jul 23, 2024 1:46 AM
Failed  discussion.cy.js • 1 failed test

View Output Video

Test Artifacts
Discussion > all discussion actions Screenshots Video
Failed  onboarding.cy.js • 1 failed test

View Output Video

Test Artifacts
Onboarding > onboarding works Screenshots Video
Failed  project.cy.js • 1 failed test

View Output Video

Test Artifacts
Project > project creation, move to team and archive Screenshots Video
Failed  task.cy.js • 1 failed test

View Output Video

Test Artifacts
Task > task actions Screenshots Video
Failed  team.cy.js • 1 failed test

View Output Video

Test Artifacts
Team > team creation, readme edit and archive Screenshots Video

Review all test suite changes for PR #278 ↗︎

@blaggacao blaggacao force-pushed the revert/re-enable-workspaces branch from 9a7b551 to 511fe16 Compare May 30, 2024 14:15
blaggacao added a commit to blaggacao/frappix that referenced this pull request May 30, 2024
@blaggacao
Copy link
Contributor Author

@netchampfaris I removed the motion stuff. I guess this could now be re-considered? It would really help me to package Gameplan in Frappix.

@blaggacao
Copy link
Contributor Author

@netchampfaris Could this be reconsidered? It's kind of a particular interest requirement, but given that the other new style apps use workspaces (afaik: Crm, Builder & Insights) there might be an independent value on aligning the code layout between projects.

As a collateral it would really help me package GamePlan properly for Frappix. 😄

@blaggacao
Copy link
Contributor Author

ping

@blaggacao
Copy link
Contributor Author

Go for it now. The future is promised to no one. - Wayne Dyer


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao blaggacao force-pushed the revert/re-enable-workspaces branch 2 times, most recently from 0ff6746 to 81649f6 Compare July 2, 2024 18:03
@blaggacao
Copy link
Contributor Author

Fears are nothing more than a state of mind. - Napoleon Hill


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Contributor Author

What the caterpillar calls the end of the world, the master calls a butterfly. - Richard Bach


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Contributor Author

Watch your thoughts, they become your words Watch your words, they become your actions Watch your actions, they become your habits Watch your habits, they become your character Watch your character, it becomes your destiny. -


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Contributor Author

You may say Im a dreamer, but Im not the only one, I hope someday you will join us, and the world will live as one. - John Lennon


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao blaggacao force-pushed the revert/re-enable-workspaces branch from 81649f6 to 6411b36 Compare July 22, 2024 19:07
@blaggacao blaggacao force-pushed the revert/re-enable-workspaces branch from 6411b36 to 34d4b8c Compare July 23, 2024 00:27
@blaggacao
Copy link
Contributor Author

I have just three things to teach: simplicity, patience, compassion. These three are your greatest treasures. - Lao Tzu


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Contributor Author

@netchampfaris Could you please verify if 41b5936 is also an independent fix? Thank you!

@blaggacao
Copy link
Contributor Author

The important thing is this: to be able at any moment to sacrifice what we are for what we could become. - Charles Dubois


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Contributor Author

Obstacles are those frightful things you see when you take your eyes off your goal. - Henry Ford


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Contributor Author

Our distrust is very expensive. - Ralph Emerson


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Contributor Author

An invincible determination can accomplish almost anything and in this lies the great distinction between great men and little men. - Thomas Fuller


Kindly help move this PR forward. Many thanks from Yours Sincerely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant