fix: update custom dt after adding SLA fields

frappe · May 29, 2021 · d645cf5 · d645cf5
1 parent bff1b1f
commit d645cf5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/erpnext/support/doctype/service_level_agreement/service_level_agreement.py b/erpnext/support/doctype/service_level_agreement/service_level_agreement.py
@@ -154,6 +154,9 @@ def create_docfields(self, meta, service_level_agreement_fields):
  existing_field = meta.get_field(field.get("fieldname"))
  self.reset_field_properties(existing_field, "DocField", field)
 
+ # to update meta and modified timestamp
+ frappe.get_doc('DocType', self.document_type).save(ignore_permissions=True)
+
  def create_custom_fields(self, meta, service_level_agreement_fields):
  for field in service_level_agreement_fields:
  if not meta.has_field(field.get("fieldname")):

diff --git a/erpnext/support/doctype/service_level_agreement/test_service_level_agreement.py b/erpnext/support/doctype/service_level_agreement/test_service_level_agreement.py
@@ -81,7 +81,7 @@ def test_custom_field_creation_for_sla_on_standard_dt(self):
 
  # check SLA custom fields created for leads
  sla_fields = get_service_level_agreement_fields()
- meta = frappe.get_meta(doctype)
+ meta = frappe.get_meta(doctype, cached=False)
 
  for field in sla_fields:
  self.assertTrue(meta.has_field(field.get("fieldname")))