client: add warning when -no-pkce is set

francoismichel · Jul 30, 2024 · c5cd829 · c5cd829
1 parent b5153dc
commit c5cd829
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/cmd/ssh3.go b/cmd/ssh3.go
@@ -355,6 +355,10 @@ func ClientMain() int {
 
 	log.Debug().Msgf("version %s", ssh3.GetCurrentSoftwareVersion())
 
+	if *noPKCE {
+		log.Warn().Msgf("Disabling PKCE is considered insecure to machine-in-the-middle attacks. Consider enabling PKCE by default!")
+	}
+
 	knownHostsPath := path.Join(ssh3Dir, "known_hosts")
 	knownHosts, skippedLines, err := ssh3.ParseKnownHosts(knownHostsPath)
 	if len(skippedLines) != 0 {