[SELS-TASK-32] [FE] - Admin Dashboard Page #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miguel21Monacillo
force-pushed
the
SPH-ELS-MONACILLO-32
branch
from
a321926 to
c8f2ac0
Compare
Mjdelima20
reviewed
Jan 17, 2024
| const AdminDashboard = () => { | ||
| return ( | ||
| <> | ||
| <title>Dashboard</title> |
There was a problem hiding this comment.
make it Admin | Dashboard
Mjdelima20
reviewed
Jan 17, 2024
| @@ -27,7 +28,7 @@ const CategoryListPage = () => { | |||
| return ( | |||
| <> | |||
| <title>Categories</title> | |||
There was a problem hiding this comment.
make it Admin | Categories
escbooster12-dev
requested changes
Jan 17, 2024
| <span className="text-blue-500 cursor-pointer"> | ||
| {' '} | ||
| {user.first_name}{' '} | ||
| </span>{' '} |
There was a problem hiding this comment.
remove all {' '} that are unnecessary.
Comment on lines
11
to
13
| ForbiddenException, | ||
|
|
||
| } from '@nestjs/common'; | ||
| import { CategoriesService } from './categories.service'; |
There was a problem hiding this comment.
can you revert this change. it's not necessary.
Comment on lines
52
to
72
| <Link to={{pathname: `/admin/category/${category.id}/addword`}}> | ||
| <button | ||
| type="button" | ||
| className="px-[5px] underline decoration-sky-500 hover:bg-sky-500" | ||
| > | ||
| Add Words | ||
| </button> | ||
| </button> </Link> | ||
| <Link to={{pathname: `/admin/category/${category.id}/edit`}}> | ||
| <button | ||
| type="button" | ||
| className="px-[5px] underline decoration-yellow-500 hover:bg-yellow-700" | ||
| > | ||
| Edit | ||
| </button> | ||
| </button> </Link> | ||
| <Link to={{pathname: `/admin/category/${category.id}/delete`}}> | ||
| <button | ||
| type="button" | ||
| className="px-[5px] underline decoration-red-500 hover:bg-red-500" | ||
| > | ||
| Delete | ||
| </button> | ||
| </button> </Link> |
There was a problem hiding this comment.
frontend/src/Routes/routes.tsx
Outdated
| @@ -22,6 +25,9 @@ const Main: React.FC = () => { | |||
| <Route path="/dashboard" element={<Dashboard />} /> | |||
| <Route path="/admin/users-list" element={<AdminUserPage />} /> | |||
| <Route path="/student/category/:id/" element={<LessonAnswerPage />} /> | |||
| <Route path="/admin/dashboard" element={<AdminDashboard/>} /> | |||
| <Route path="/admin/categories" element={<CategoryListPage/>} /> | |||
| <Route path="/admin/category/:id/addword" element={<AddWordPage/>} /> | |||
There was a problem hiding this comment.
use kebab case for routes
Suggested change
| <Route path="/admin/category/:id/addword" element={<AddWordPage/>} /> | |
| <Route path="/admin/category/:id/add-word" element={<AddWordPage/>} /> |
| interface NavbarProps { | ||
| title: string; | ||
| } | ||
| const AdminNavbar: React.FC<NavbarProps> = ({ title }) => { |
There was a problem hiding this comment.
Suggested change
| const AdminNavbar: React.FC<NavbarProps> = ({ title }) => { | |
| const AdminNavbar = ({ title } : NavbarProps) => { |
Comment on lines
1
to
2
| import UserProfile from '../user.png'; | ||
| import users from '../../dummydata'; |
Miguel21Monacillo
changed the title
Miguel21Monacillo
force-pushed
the
SPH-ELS-MONACILLO-32
branch
from
4607b1d to
e98e0e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana
[Commands]
npm start[Pre-conditions]
[Expected Output]
[Screenshots]