feat: pass buttons' props separately to FrameButtonContainer #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
michalkvasnicak
approved these changes
Sep 25, 2024
| theme?.Button || ({} as TStylingProps) | ||
| ) | ||
| ), | ||
| buttonsProps: buttonsProps, |
There was a problem hiding this comment.
nit pick - shorthand here 😄
normanzb
reviewed
Sep 25, 2024
| @@ -259,40 +287,19 @@ export function BaseFrameUI<TStylingProps extends Record<string, unknown>>({ | |||
| buttonsContainer: | |||
| frameUiState.status === "loading" || | |||
| !frameUiState.frame.buttons || | |||
| frameUiState.frame.buttons.length === 0 | |||
| frameUiState.frame.buttons.length === 0 || | |||
| !buttonsProps | |||
There was a problem hiding this comment.
the conditions are pretty much the same here, could just do with a buttonProps && components....?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Passes button props alongside the button elements to the
FrameButtonContainercomponent in case the props need to be transformed or reordered at render time.Merge Checklist