Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make local setup docs more explicit & apply DRY on http client class #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kritchie
Copy link

Hi,

The changes I'm proposing are in the spirit of enhancing the onboarding process when starting out with the library.
It wasn't clear for me what the uri should have contained initially, I assumed a combination of hostname:port would suffice but apparently I was wrong as I kept getting some HTTP errors.

I propose changing slightly the initialization of the base_uri to abstract away the need to pass the custom routes in the configuration uri. In my opinion, it should be invisible to the user.

Also, after digging into the code, I stumbled upon the Client class code and I felt I could make it simpler by remove the try/except snippet repetitions (DRY principle).

Also, by the looks of it, it doesn't look like there's an extensive test suite for this package, that's why my PR doesn't include any update in that regards.

Thanks! Looking forward to the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant