Make local setup docs more explicit & apply DRY on http client class #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The changes I'm proposing are in the spirit of enhancing the onboarding process when starting out with the library.
It wasn't clear for me what the
uri
should have contained initially, I assumed a combination ofhostname:port
would suffice but apparently I was wrong as I kept getting some HTTP errors.I propose changing slightly the initialization of the
base_uri
to abstract away the need to pass the custom routes in the configurationuri
. In my opinion, it should be invisible to the user.Also, after digging into the code, I stumbled upon the
Client
class code and I felt I could make it simpler by remove thetry/except
snippet repetitions (DRY principle).Also, by the looks of it, it doesn't look like there's an extensive test suite for this package, that's why my PR doesn't include any update in that regards.
Thanks! Looking forward to the feedback.