Added Some Documentation to Entity.sol, Fragment.sol, RezProxy.sol, RoyaltiesReceiver.sol, UnstructuredStorage.sol and Vault.sol #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oyaltiesReceiver.sol, UnstructuredStorage.sol and Vault.sol
added 2 commits
February 22, 2022 14:58
…ity.sol, PreERC721Factory.sol, PreERC721.sol and PreERC721Genesis.sol
sinkingsugar
reviewed
Mar 6, 2022
| /// @dev Note: The Fragment must have been created with `updateable` set to true - otherwise the update is not allowed | ||
| /// @param signature - A signature from the the state variable `_delegate` | ||
| /// @param id - ¿The ID of the Fragment? | ||
| /// @param environment - ¿The New Data of the Fragment? | ||
| function update( |
sinkingsugar
reviewed
Mar 6, 2022
| @@ -60,6 +60,8 @@ contract PreERC721 is ERC721, Initializable, Ownable, RoyaltiesReceiver { | |||
|
|
|||
| /// Overrides | |||
| /// | |||
| /// @notice Returns the name of this ERC-721 Contract | |||
| /// @dev ¿I am not sure what _getImmutableVariablesOffset does? | |||
There was a problem hiding this comment.
_getImmutableVariablesOffset is complex, but basically it's almost a hack inside EVM to get a location in memory where we stored things when we created this contract in a very cheap way
sinkingsugar
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.