add bounds min,max #978
Open
add bounds min,max #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guusw
reviewed
May 10, 2024
shards/gfx/gltf/gltf.cpp
Outdated
| return linalg::mul(linalg::mul(linalg::mul(matrix, T), R), S); | ||
| } | ||
|
|
||
| void computeBoundingBox(const tinygltf::Node &node, const tinygltf::Model &model, linalg::vec<double, 3> &global_min, |
There was a problem hiding this comment.
Slight waste in case a model reuses a lot of meshes, you could cache bounds per mesh and just retransform them later
There was a problem hiding this comment.
ah cos it goes by node hmmm are you collecting meshes somewhere already?
There was a problem hiding this comment.
there's a bunch of maps in the Loader structure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #978 +/- ##
==========================================
+ Coverage 80.18% 80.21% +0.03%
==========================================
Files 335 335
Lines 53786 53864 +78
==========================================
+ Hits 43129 43208 +79
+ Misses 10657 10656 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan