Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPHINCS+ #2

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

SPHINCS+ #2

wants to merge 14 commits into from

Conversation

fpseverino
Copy link
Owner

No description provided.

Copy link

@Sajjon Sajjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun! First time I hear about SPHINCS.

Sources/_CryptoExtras/SPX/SPX_boring.swift Outdated Show resolved Hide resolved
Sources/_CryptoExtras/SPX/SPX_boring.swift Outdated Show resolved Hide resolved
Sources/_CryptoExtras/SPX/SPX_boring.swift Outdated Show resolved Hide resolved
@fpseverino
Copy link
Owner Author

Hi @Sajjon, thanks for the feedback!

@Sajjon
Copy link

Sajjon commented Jun 14, 2024

Hi @Sajjon, thanks for the feedback!

NP! I would also specify key size, this seem to be SPHINCS+-128s I think, see this table

Screenshot 2024-06-14 at 20 32 50

You might wanna GYB, like this all different variants - if they are supported by CCryptoBoringSSL

@fpseverino
Copy link
Owner Author

You might wanna GYB, like this all different variants - if they are supported by CCryptoBoringSSL

Unfortunately, right now they are not, but I'll keep that in mind for when they will be added

@Sajjon
Copy link

Sajjon commented Jun 14, 2024

Right! So maybe rename the enum SPX -> SPHINCS128s or Spx128s or similar?

Or at least document that it is that variant :)

Update to latest commits from `main`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants