Change choice of q in qary-lattice generation #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let random lattice generation use the methods changed in fplll/fplll#526. Note: adds support for values of 'q' above 2^31 when calling IntegerMatrix.random with methods 'ntrulike', 'ntrulike2' and 'qary'.
malb
reviewed
Jun 14, 2024
tests/test_gso.py
Outdated
| @@ -11,9 +11,9 @@ | |||
|
|
|||
|
|
|||
| if sys.maxsize >= 2**62: | |||
| dimensions = ((0, 0), (2, 2), (3, 3), (10, 10), (30, 30), (50, 50), (60, 60)) | |||
| dimensions = ((1, 1), (2, 2), (3, 3), (10, 10), (30, 30), (50, 50), (60, 60)) | |||
There was a problem hiding this comment.
I think we should check these, those can happen as corner cases of higher-level algorithms
There was a problem hiding this comment.
Fair enough, I have changed matrix generation in this test file to use bits=max(1, m) in that case, as bits=0 gave a Segmentation Fault.
- Setting bits >= 1 prevents a SignalError in IntegerMatrix.randomize. - Add assertion for the check introduced in commit b0d4ca4 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let random lattice generation use the methods changed in fplll/fplll#526.
Note: adds support for values of 'q' above 2^31 when calling IntegerMatrix.random with methods 'ntrulike', 'ntrulike2' and 'qary'.
Note: G6K does not need any modification.
Resolves: post by @malb in fplll/fplll#526 (comment)