Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated poetry lock #98

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

kenibrewer
Copy link
Contributor

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests! (Not relevant)
  • Documentation in docs is updated (Not relevant)

Description of changes

This minor change replaces the deprecated poetry lock --check with the new command poetry check --lock.

This will resolve the following warning that currently appears when using make check.

> make check
🚀 Checking Poetry lock file consistency with 'pyproject.toml': Running poetry lock --check
poetry lock --check is deprecated, use `poetry check --lock` instead.
poetry.lock is consistent with pyproject.toml.
...

@kenibrewer kenibrewer changed the title Chore: poetry lock deprecation fix: replace deprecated poetry lock Oct 18, 2023
@fpgmaas
Copy link
Owner

fpgmaas commented Oct 18, 2023

Thanks for the contribution @kenibrewer! Could you change it here as well?

@kenibrewer kenibrewer force-pushed the chore/poetry-lock-deprecation branch from 044aaa7 to 8556418 Compare October 18, 2023 18:21
@kenibrewer
Copy link
Contributor Author

@fpgmaas Done. Thanks for pointing that out!

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #98 (8556418) into main (49756a7) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #98   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          5       5           
=====================================
  Misses         5       5           

@fpgmaas fpgmaas merged commit f853ca3 into fpgmaas:main Oct 18, 2023
8 checks passed
@kenibrewer kenibrewer deleted the chore/poetry-lock-deprecation branch October 18, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants