Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyright support #125

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Add pyright support #125

merged 5 commits into from
Oct 2, 2024

Conversation

szvsw
Copy link
Contributor

@szvsw szvsw commented Sep 25, 2024

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

This enables user-selection of the typechecking engine, using mypy and pyright as the available options. The main changes are to:

  1. Install the appropriate dependency.
  2. Update the relevant pyproject.toml section
  3. Update the makefile to run the appropriate test.
  4. Update the GH action to run the appropriate test
  5. Update the tox to run the appropriate test NB: I am not a tox user so I haven't tested this part out yet, but it seems like it should be fine!

I have not yet added tests as I'm curious what you think the correct approach should be for the typechecking tests.

Closes #106

@szvsw szvsw marked this pull request as ready for review September 26, 2024 13:56
@szvsw szvsw mentioned this pull request Sep 26, 2024
@fpgmaas
Copy link
Owner

fpgmaas commented Oct 2, 2024

Thanks for your contribution!

@fpgmaas fpgmaas merged commit 4355a33 into fpgmaas:main Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyright vs mypy
2 participants