Fixed no codecov issue (#61)

* Fixed no codecov issue * fixed docs
fpgmaas · Oct 20, 2022 · 0cd6cd6 · 0cd6cd6
1 parent 2d3d45a
commit 0cd6cd6
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 5 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -13,4 +13,9 @@ repos:
   - repo: https://github.com/PyCQA/flake8
     rev: "5.0.4"
     hooks:
-      - id: flake8
+      - id: flake8
+  - repo: https://github.com/fpgmaas/deptry.git
+    rev: f80c2263a201b868c469e7cb419a5e9b363dcbf8
+    hooks:
+    - id: deptry
+
diff --git a/docs/index.md b/docs/index.md
@@ -71,9 +71,9 @@ git push -u origin main
 
 Finally, install the environment and the pre-commit hooks with
 
- ```bash
- make install
- ```
+```bash
+make install
+```
 
 You are now ready to start development on your project! The CI/CD
 pipeline will be triggered when you open a pull request, merge to main,

diff --git a/hooks/post_gen_project.py b/hooks/post_gen_project.py
@@ -26,4 +26,4 @@ def remove_dir(filepath: str) -> None:
 
     if "{{cookiecutter.codecov}}" != "y":
         remove_file("codecov.yaml")
-        remove_file(".github/workflows/validate-codecov-config.yaml")
+        remove_file(".github/workflows/validate-codecov-config.yml")
diff --git a/tests/test_cookiecutter.py b/tests/test_cookiecutter.py
@@ -46,6 +46,7 @@ def test_using_pytest(cookies, tmp_path):
 def test_cicd_contains_artifactory_secrets(cookies, tmp_path):
     with run_within_dir(tmp_path):
         result = cookies.bake(extra_context={"publish_to": "artifactory"})
+        assert result.exit_code == 0
         for text in ["ARTIFACTORY_URL", "ARTIFACTORY_USERNAME", "ARTIFACTORY_PASSWORD"]:
             assert file_contains_text(f"{result.project_path}/.github/workflows/on-release-main.yml", text)
         assert file_contains_text(f"{result.project_path}/Makefile", "build-and-publish")
@@ -54,13 +55,15 @@ def test_cicd_contains_artifactory_secrets(cookies, tmp_path):
 def test_cicd_contains_pypi_secrets(cookies, tmp_path):
     with run_within_dir(tmp_path):
         result = cookies.bake(extra_context={"publish_to": "pypi"})
+        assert result.exit_code == 0
         assert file_contains_text(f"{result.project_path}/.github/workflows/on-release-main.yml", "PYPI_TOKEN")
         assert file_contains_text(f"{result.project_path}/Makefile", "build-and-publish")
 
 
 def test_dont_publish(cookies, tmp_path):
     with run_within_dir(tmp_path):
         result = cookies.bake(extra_context={"publish_to": "none"})
+        assert result.exit_code == 0
         assert not file_contains_text(
             f"{result.project_path}/.github/workflows/on-release-main.yml", "make build-and-publish"
         )
@@ -69,6 +72,7 @@ def test_dont_publish(cookies, tmp_path):
 def test_mkdocs(cookies, tmp_path):
     with run_within_dir(tmp_path):
         result = cookies.bake(extra_context={"mkdocs": "y"})
+        assert result.exit_code == 0
         assert file_contains_text(f"{result.project_path}/.github/workflows/on-release-main.yml", "mkdocs gh-deploy")
         assert file_contains_text(f"{result.project_path}/Makefile", "docs:")
         assert os.path.isdir(f"{result.project_path}/docs")
@@ -77,6 +81,7 @@ def test_mkdocs(cookies, tmp_path):
 def test_not_mkdocs(cookies, tmp_path):
     with run_within_dir(tmp_path):
         result = cookies.bake(extra_context={"mkdocs": "n"})
+        assert result.exit_code == 0
         assert not file_contains_text(
             f"{result.project_path}/.github/workflows/on-release-main.yml", "mkdocs gh-deploy"
         )
@@ -87,6 +92,7 @@ def test_not_mkdocs(cookies, tmp_path):
 def test_tox(cookies, tmp_path):
     with run_within_dir(tmp_path):
         result = cookies.bake()
+        assert result.exit_code == 0
         assert file_contains_text(
             f"{result.project_path}/.github/workflows/on-release-main.yml", "poetry add tox-gh-actions"
         )
@@ -103,24 +109,28 @@ def test_tox(cookies, tmp_path):
 def test_dockerfile(cookies, tmp_path):
     with run_within_dir(tmp_path):
         result = cookies.bake(extra_context={"dockerfile": "y"})
+        assert result.exit_code == 0
         assert os.path.isfile(f"{result.project_path}/Dockerfile")
 
 
 def test_not_dockerfile(cookies, tmp_path):
     with run_within_dir(tmp_path):
         result = cookies.bake(extra_context={"dockerfile": "n"})
+        assert result.exit_code == 0
         assert not os.path.isfile(f"{result.project_path}/Dockerfile")
 
 
 def test_codecov(cookies, tmp_path):
     with run_within_dir(tmp_path):
         result = cookies.bake()
+        assert result.exit_code == 0
         assert os.path.isfile(f"{result.project_path}/codecov.yaml")
         assert os.path.isfile(f"{result.project_path}/.github/workflows/validate-codecov-config.yml")
 
 
 def test_not_codecov(cookies, tmp_path):
     with run_within_dir(tmp_path):
         result = cookies.bake(extra_context={"codecov": "n"})
+        assert result.exit_code == 0
         assert not os.path.isfile(f"{result.project_path}/codecov.yaml")
         assert not os.path.isfile(f"{result.project_path}/.github/workflows/validate-codecov-config.yml")