Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove register offset define statements #5

Open
tvannoy opened this issue Oct 6, 2019 · 2 comments
Open

Remove register offset define statements #5

tvannoy opened this issue Oct 6, 2019 · 2 comments
Assignees
@tvannoy @fe-wickham
Labels
good first issue Good for newcomers

Comments

@tvannoy
Copy link
Member

tvannoy commented Oct 6, 2019

If the #define register offsets don't get defined in the json file, some defaults get put in the generated C code, but they don't get used.

We could not include the #defines in this case. It might be good to create the offsets in the json file from Matlab.
@tvannoy tvannoy added the good first issue Good for newcomers label Mar 11, 2020
@fe-wickham
Copy link
Member

We can probably just remove the #define statements because they aren't actually used

@tvannoy tvannoy changed the title Device driver register offset define statements Remove register offset define statements Jan 27, 2021
@tvannoy
Copy link
Member Author

tvannoy commented Jan 27, 2021

Agreed. Updated the title accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tvannoy tvannoy

@fe-wickham fe-wickham

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tvannoy @fe-wickham